Conversation
CoolCat467
left a comment
CoolCat467
left a comment
There was a problem hiding this comment.
Looks good as far as I can tell, not sure what difference between open_process and _open_process is immediately though and had a question about empty bytes vs None functionality changes
|
|
jakkdl
left a comment
jakkdl
left a comment
There was a problem hiding this comment.
See #3264 (comment) for more discussion on structuring the CI yaml.
I'm spent on arguing about it, so don't have an opinion for now.
| # 'CPython' -> '3.9.0-alpha - 3.9.X' | ||
| # 'PyPy' -> 'pypy-3.9' | ||
| python-version: ${{ fromJSON(format('["{0}", "{1}"]', format('{0}.0-alpha - {0}.X', matrix.python), matrix.python))[startsWith(matrix.python, 'pypy')] }} | ||
| python-version: '${{ matrix.python }}' |
There was a problem hiding this comment.
was this the logic that allowed 3.14-dev? (and the comment being outdated/incorrect) If so, and we're getting rid of it, then we should simplify continue-on-error.
There was a problem hiding this comment.
The new logic allows both 3.14-dev and 3.14, which will both point to the latest beta. The only difference is that one indicates that Trio doesn't support it completely yet so is allowed to fail.
There was a problem hiding this comment.
To be clear, the comment you posted above was not possible (I didn't realized it at the time) due to the old logic here. The options are:
- remove the old logic, keep the continue-on-error
- keep the old logic, remove the continue-on-error
I chose the first because I think ideally we would keep e.g. 3.15-dev until 3.15 releases a beta (so failure doesn't matter), then change it to 3.15 along with any necessary changes to ensure that Trio supports 3.15.
|
Did you try removing the skipif from https://github.com/python-trio/trio/pull/3264/files#diff-569465da536cb2feb60e6d4707912f153c1a981dd0a08b8ed3e3bac2b7236290 i.e. 2nd item in #3267 |
No because I saw the back port PR isn't merged yet, but I could try that. |
3 participants
A combination of a few changes that I think make things simpler:
_open_processto simplify type ignore (I was testing out AI models on_subprocess.pyand those are the valid issues they reported!)